Skip to content

Conversation

@Alopalao
Copy link

@Alopalao Alopalao commented Apr 7, 2022

Based on issue #14
Added the toggle button to enable or disable an interface. It has the similar function to the switch and link toggle button.
Update:
-It needs the topology PR #85

@viniarck viniarck requested review from rmotitsuki and viniarck April 8, 2022 16:47
@rmotitsuki
Copy link

I think that the "Enable" button is too close to the "back" button. If we change the layout so that each one is on opposite sides it will look better.
image
Adding a DIV wrapper will do the trick.
<div style="display:flex;justify-content: space-between;">

@Alopalao
Copy link
Author

CSS updated on commit 088b432f76f3fd4f6714d77cd9eb751609413497
Version updated on commit fd7973df88fa734cf0deb4bd24a72d1437e7d84b
Changlog updated on commit 306a7f1ecfea7b32de83f4f3e1de8cebf27f38f4

@viniarck viniarck self-requested a review April 22, 2022 17:27
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great contribution @Alopalao. @rmotitsuki waiting for you approval, when you have the chance to review again.

@Alopalao Alopalao closed this Apr 23, 2022
@Alopalao Alopalao reopened this Apr 23, 2022
@Alopalao
Copy link
Author

Moved style to css class 98709b6fc2c2bebe3eeaef7eecfdf452edff4cbb

@viniarck viniarck merged commit a510526 into kytos-ng:master Apr 25, 2022
@Alopalao Alopalao deleted the fix/issue_14 branch September 27, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants